-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the signed-resource requirement for account SAS tokens #396
base: dev
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Commenter does not have sufficient privileges for PR 396 in repo Azure/azure-storage-cpp |
Hi Jinming, Sorry for the build break, I swear I built this locally. But this brings up a different issue. Should the conditional that I removed actually be removed, or should we be passing false to the function in case an account SAS is being used? Looks like "require_signed_resource" is only set to true in two places:
Should one of these (or both) be set to false instead? Tom |
@tomswedlund Hi, thanks for your contribution. I believe the CI failure has nothing to do with the change in this PR. I'm gonna take some time to fix Azure pipelines. |
HI Jinming, I see a build failure with the following error: Looks like the 'require_signed_resource' function param is no longer being used because of my change, and hence the error. Should this parameter be removed altogether? Or should we passing 'false' in the two places I mentioned in my last comment? Thanks, |
Addressing the following bug: #383